-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaffolding for persisting resolution of logic names #2448
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
force-pushed
the
fd/parameterize-expr2
branch
from
November 25, 2024 12:04
92f2050
to
b850538
Compare
facundominguez
force-pushed
the
fd/parameterize-expr2
branch
from
November 25, 2024 13:26
214fc37
to
c8d68bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step for #2169
This PR has three kinds of commits.
Scope checks would fail when a name is not in scope. This is something that LH did already by delegating to liquid-fixpoint. In an example like
liquid-fixpoint would report an error like
With this PR a more precise error is produced
The results of name resolution are not yet persisted, but much of the machinery needed for it is provided now in the
LHNameResolution
module.