Get rid of wiredin reflections #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundominguez
force-pushed
the
fd/no-wired-reflects
branch
from
42ca04d to
4472961
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only wired-in reflected function was composition (
.), and it turned out that it can be implemented withassume reflect. Therefore this PR eliminates all the mechanism for wiredin reflects.This PR also fixes a flaw I found along the way. LH was omitting to add the sorts of imported reflected functions in the fixpoint queries. This only happened when the corresponding Haskell function is not in scope, which can be the case when functions are defined in
LHAssumptionmodules.