Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for lambdas :) #2465

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Support for lambdas :) #2465

merged 10 commits into from
Dec 16, 2024

Conversation

AlecsFerra
Copy link
Contributor

@AlecsFerra AlecsFerra commented Dec 12, 2024

Its breaking two tests related to typeclasses, both caused by the same file that breaks elaboration.

Companion PR in LF: ucsd-progsys/liquid-fixpoint#725

@AlecsFerra
Copy link
Contributor Author

Some examples

@nikivazou
Copy link
Member

That is amazing!!!! Though some tests seems to fail :'(

@AlecsFerra
Copy link
Contributor Author

That is amazing!!!! Though some tests seems to fail :'(

Yeah is just the usual suspect tests/classes/pos/STMonad.hs everything else should work

@AlecsFerra
Copy link
Contributor Author

Added some tests and fixed the issue with tests/classes/pos/STMonad.hs thanks to @nikivazou

.gitmodules Outdated Show resolved Hide resolved
Copy link
Collaborator

@facundominguez facundominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AlecsFerra! I make one request for documentation below.

If there are some limitations to keep in mind, it may be worth mentioning them in the user documentation.

@AlecsFerra
Copy link
Contributor Author

If there are some limitations to keep in mind, it may be worth mentioning them in the user documentation.

AFAIK there are no limitations

Copy link
Collaborator

@facundominguez facundominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments!

Copy link
Collaborator

@facundominguez facundominguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nikivazou nikivazou merged commit 791567f into ucsd-progsys:develop Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants