-
Notifications
You must be signed in to change notification settings - Fork 2
The review workflow for comparing the Chinese translation of samvera hyrax locales file
-
To get to the compare view, append
/compare
to your repository's path: https://github.com/samvera/hyrax/compare/ -
Enter two arbitrary commits In left side
base
and right sidecompare
. Comparisons between commits are made by providing either the full SHA hash or the short seven-character code. For example:
Inbase
enter commit “8186544”, which is the last commit for chinese locale config dated on Apr 14.
Incompare
enter commit “181141d”, which is the latest commit in master branch dated on Aug. 23rd.
Here is the url for this example: https://github.com/samvera/hyrax/compare/8186544...181141d -
After the Comparing changes result page loaded, click “Files changed” tab —> search “hyrax.zh.yml” —> click “load diff” under config/locales/hyrax.zh.yml, The result page shows the new added/removed lines and their line number for hyax.zh.yml file between two commits time period(For the above example, from Apr. 14th to Aug. 23rd) which would be easy to review and compare the changes.
-
See missing internationalization keys:
https://github.com/samvera/hyrax/wiki/Testing-internationalization-(i18n)-support -
Review and edit the translation.
-
Add new updates to hyax.zh.yml using YAML format.
-
Run rubocop to make sure all tests passed.