Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: Optimizing table performance #3751

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Perf: Optimizing table performance #3751

wants to merge 2 commits into from

Conversation

natamox
Copy link
Collaborator

@natamox natamox commented Nov 11, 2024

Avoid listening to changes in the entire tableElement or global tableStroe in the cell

Let the upper layer handle the changes of table column width and row height

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

Avoid listening to changes in the entire tableElement or global tableStroe in the cell

Let the upper layer handle the changes of table column width and row height
Copy link

codesandbox bot commented Nov 11, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: fe0089d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plate ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 4:53am

@zbeyens
Copy link
Member

zbeyens commented Nov 18, 2024

Some regressions:

2024-11-18.at.17.41.55.mp4
2024-11-18.at.17.42.56.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants