Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various documentation improvements #12

Merged
merged 13 commits into from
Dec 12, 2022
Merged

Various documentation improvements #12

merged 13 commits into from
Dec 12, 2022

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Dec 2, 2022

No description provided.

udoprog
udoprog reviewed Dec 2, 2022
View reviewed changes
Copy link
Owner

@udoprog udoprog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some comments.

@udoprog udoprog added the enhancement New feature or request label Dec 2, 2022
udoprog
udoprog reviewed Dec 5, 2022
View reviewed changes
udoprog
udoprog reviewed Dec 5, 2022
View reviewed changes
@udoprog
Copy link
Owner

udoprog commented Dec 10, 2022

Heads up: I will be a bit slow due to December-related activities in general. But I generally find time to go through Github every other day or so.

@Be-ing Be-ing force-pushed the documentation branch 3 times, most recently from 918ffb8 to aba42db Compare December 10, 2022 17:48
@Be-ing
Copy link
Contributor Author

Be-ing commented Dec 10, 2022

Alright, I think this is ready to merge now.

udoprog
udoprog reviewed Dec 12, 2022
View reviewed changes
udoprog
udoprog reviewed Dec 12, 2022
View reviewed changes
udoprog
udoprog previously approved these changes Dec 12, 2022
View reviewed changes
@udoprog udoprog merged commit a3d7f5a into udoprog:main Dec 12, 2022
@udoprog
Copy link
Owner

udoprog commented Dec 12, 2022

Merged mostly as-is to move along. Removed the line about the wrap module that I wasn't sure about so you can introduce it at at another commit if you really want it.

@udoprog udoprog changed the title various documentation improvements Various documentation improvements Dec 12, 2022
@Be-ing Be-ing deleted the documentation branch December 12, 2022 14:51
@udoprog udoprog mentioned this pull request Dec 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udoprog udoprog udoprog approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @udoprog