Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ portuguese default locale #258

Merged
merged 3 commits into from
Dec 24, 2023
Merged

feat: ✨ portuguese default locale #258

merged 3 commits into from
Dec 24, 2023

Conversation

viniciusamelio
Copy link
Contributor

📜 Description

Adding default portuguese (pt) locale

💡 Motivation and Context

Currently there isn't a FeedbackLocalizations for the Portuguese language

💚 How did you test it?

Running the example app with locale setted as "pt"

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Add it as a default localization

ueman
ueman approved these changes Dec 11, 2023
View reviewed changes
Copy link
Owner

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is awesome!

@ueman ueman merged commit c30dcda into ueman:master Dec 24, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viniciusamelio @ueman