This repository has been archived by the owner on Nov 10, 2020. It is now read-only.
forked from Jbcampbe/genesys-webcomponents
-
Notifications
You must be signed in to change notification settings - Fork 1
feat(table component): columns resizing, reordering, sorting and rows selecting #7
Open
dmitryueno
wants to merge
29
commits into
master
Choose a base branch
from
table-component-additional
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added guards to resizeObserver calls if it is undefined
added expanded layout COMUI-245
fix(gux-table): resizeObserver not present in spec tests
chore(translations): translation updates
feat(gux-pagination): added expanded layout
…mponents into table-component-additional
Klimonov
approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Dropdown options loaded asynchronously were failing to have event handlers attached because the handlers were set on individual elements during the elment bootstrap lifecyle. This switches event handling to a delegation pattern, where all of the events are handled in a parent element and their origin is checked in order to see how they should be handled. COMUI-255
exporting common color variables for use in client apps COMUI-194
feat(color-styles): exporting common color variables
fix(gux-dropdown): better handle asynchronously loaded options
fix(doc-site): fix the sort order of components
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table component columns resizing, reordering, sorting and rows selecting features implementation
re https://github.com/MyPureCloud/genesys-webcomponents/issues/6