Fix keyboard shortcut related issue #17

Polyglot.safariextension/Info.plist

@@ -13,9 +13,9 @@
 	<key>CFBundleInfoDictionaryVersion</key>
 	<string>6.0</string>
 	<key>CFBundleShortVersionString</key>
-	<string>2.1.0</string>
+	<string>2.2.0</string>
 	<key>CFBundleVersion</key>
-	<string>2.1.0</string>
+	<string>2.2.0</string>
 	<key>Chrome</key>
 	<dict>
 		<key>Context Menu Items</key>

Polyglot.safariextension/Settings.plist

@@ -3,6 +3,8 @@
 <plist version="1.0">
 <array>
 	<dict>
+		<key>DefaultValue</key>
+		<string>en</string>
 		<key>Key</key>
 		<string>targetLanguage</string>
 		<key>Title</key>

Polyglot.safariextension/global.js

@@ -1,8 +1,16 @@
 const { translate } = require('./api');
 
 // Get settings
+const settingsKeys = [
+  'keyValue',
+  'useCtrlKey',
+  'useMetaKey',
+  'useShiftKey',
+  'useAltKey',
+  'targetLanguage',
+];
 let settings = {};
-Object.keys(safari.extension.settings).forEach(key => {
+settingsKeys.forEach(key => {
   settings[key] = safari.extension.settings[key];
 });
 

Polyglot.safariextension/injected.js

@@ -39,10 +39,10 @@ function handleKeypress(e) {
     return;
   }
 
-  const applyMeta = settings.useMetaKey ? e.metaKey : true;
-  const applyShift = settings.useShiftKey ? e.shiftKey : true;
-  const applyCtrl = settings.useCtrlKey ? e.ctrlKey : true;
-  const applyAlt = settings.useAltKey ? e.altKey : true;
+  const applyMeta = settings.useMetaKey === 'true' ? e.metaKey : true;
+  const applyShift = settings.useShiftKey === 'true' ? e.shiftKey : true;
+  const applyCtrl = settings.useCtrlKey === 'true' ? e.ctrlKey : true;
+  const applyAlt = settings.useAltKey === 'true' ? e.altKey : true;
   const applyKey = settings.keyValue.charCodeAt(0) === e.keyCode;
   if (applyMeta && applyShift && applyCtrl && applyAlt && applyKey) {
     e.preventDefault();

docs/manifest.plist

@@ -6,15 +6,15 @@
   <array>
     <dict>
       <key>CFBundleIdentifier</key>
-      <string>co.randompaper.safari.polyglot</string>
+      <string>io.uechi.safari.polyglot</string>
       <key>Developer Identifier</key>
       <string>58XDWHK3JX</string>
       <key>CFBundleVersion</key>
-      <string>2.1.0</string>
+      <string>2.2.0</string>
       <key>CFBundleShortVersionString</key>
-      <string>2.1.0</string>
+      <string>2.2.0</string>
       <key>URL</key>
-      <string>https://github.com/uetchy/Polyglot/releases/download/v2.1.0/Polyglot.safariextz</string>
+      <string>https://github.com/uetchy/Polyglot/releases/download/v2.2.0/Polyglot.safariextz</string>
       <key>Update From Gallery</key>
       <false/>
     </dict>

package.json

@@ -4,8 +4,7 @@
   "scripts": {
     "start": "webpack -w",
     "build": "webpack",
-    "format":
-      "prettier --write --no-semi --single-quote '{!(node_modules)/**/!(*.entry).{js,jsx},*.js}'"
+    "format": "prettier --write --no-semi --single-quote '{!(node_modules)/**/!(*.entry).{js,jsx},*.js}'"
   },
   "dependencies": {
     "whatwg-fetch": "^2.0.1"
@@ -19,7 +18,12 @@
     "webpack": "^3.10.0"
   },
   "babel": {
-    "presets": ["es2015", "stage-3"],
-    "plugins": ["transform-runtime"]
+    "presets": [
+      "es2015",
+      "stage-3"
+    ],
+    "plugins": [
+      "transform-runtime"
+    ]
   }
 }