Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: package json issues #169

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: package json issues #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e8218c
Add vercel and cross-env to package.json
KonradLinkowski Jun 4, 2022
cef2b23
Remove "install vercel" from contributing.md
KonradLinkowski Jun 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,11 @@

## Setup

Install `vercel`:

```
npm i -g vercel
```

then install deps and fire up a dev server.
Install deps and fire up a dev server.

```
yarn install
vc dev
yarn dev
```

Run tests before creating a pull request:
Expand Down
10 changes: 6 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
"description": "namae saves your time searching around registries and checking if the desired name is ready for use.",
"author": "Yasuaki Uechi <[email protected]> (https://uechi.io/)",
"scripts": {
"build": "NODE_ENV=production react-scripts build",
"dev": "BROWSER=none react-scripts start",
"build": "cross-env NODE_ENV=production react-scripts build",
"dev": "cross-env BROWSER=none react-scripts start",
"eject": "react-scripts eject",
"prepare": "husky install",
"readme": "mdmod README.md --define.owner uetchy",
"test": "tsc --noEmit && jest --coverage && CI=true react-scripts test --coverage"
"test": "tsc --noEmit && jest --coverage && cross-env CI=true react-scripts test --coverage"
},
"dependencies": {
"@sentry/browser": "^6.19.2",
Expand Down Expand Up @@ -55,6 +55,7 @@
"@vercel/build-utils": "^2.15.0",
"@vercel/node": "^1.14.0",
"codacy-coverage": "^3.4.0",
"cross-env": "^7.0.3",
"husky": "^7.0.4",
"i18next-node-fs-backend": "^2.1.3",
"mdmod": "^2.0.0",
Expand All @@ -64,7 +65,8 @@
"prettier": "^2.6.1",
"pretty-quick": "^3.1.3",
"ts-jest": "^27.1.4",
"typescript": "^4.6.3"
"typescript": "^4.6.3",
"vercel": "^25.0.0"
},
"license": "Apache-2.0",
"browserslist": {
Expand Down
Loading