Update test_packets_sub9.py #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hola, your friendly InvestiGator bot here with another message! Because this PR was closed/merged, I'm going to remove the docs preview for now. Have a great day! Go gators! 🐊 |
cbrxyz
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Great job! Just look over the one comment and also run your code through pre-commit: https://uf-mil.github.io/docs/software/devtools.html#pre-commit!
| @@ -6,9 +6,9 @@ | |||
| from mil_usb_to_can.sub9 import Packet | |||
| from mil_usb_to_can.sub9.packet import SYNC_CHAR_1, SYNC_CHAR_2 | |||
|
|
|||
|
|
|||
| # payload_format must follow format characters listed here: https://docs.python.org/3/library/struct.html | |||
There was a problem hiding this comment.
I'm not sure we need this comment. This is clear if you're using the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new tests for sub9 usb to can driver
Screenshot or Video
Related Issues
- Closes #1092
Testing
All new tests pass
About This PR