Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables headings updated to include resourceTypeId which then generates route to the resource #19

Open
wants to merge 8 commits into
base: clarin-v7
Choose a base branch
from

Conversation

LINOSNCHENA
Copy link

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

missing field in a table

Analysis

The field resourceTypeId was missing on the table for hundlers

Analysis

Interface was not consistant with object

Problems

The interface had to be changed and a helper function created to handle the routing. The problem was solved

Copy link
Member

@kosarko kosarko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the links are generated only on odd lines
  • the resource-type-id column heading is untranslated
  • see automated test report failures (for example the linter)
  • see the comment for local.cfg
  • don't remove yarn.lock

image

docker/local.cfg Show resolved Hide resolved
@LINOSNCHENA LINOSNCHENA requested a review from kosarko December 4, 2024 15:32
@kosarko
Copy link
Member

kosarko commented Dec 5, 2024

  • the links are generated only on odd lines

This actually reflects the status in database, it seems...

@kosarko
Copy link
Member

kosarko commented Dec 5, 2024

@LINOSNCHENA I'd suggest a bit of a cleanup:

  • could you rebase your changes on top of current clarin-v7 (this should limit the number of changed files)
  • would it be possible to change your IDE setup and/or not reformat lines which you are not actually touching? (this should limit the number of changes per file, to only those necessary)
  • can you move the getHandlePageRoute method from src/app/community-page/community-page-routing-paths to handle-table.component.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants