[rules] [clausification, tautologies] Support for arguments #48
+69
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The semantics of the rules `and`, `not_or`, `and_pos`, and `or_neg` changed so that now they expect an argument as to the position in which the concluding element is from an n-ary application of the operators `and` or `or`.
bpandreotti
requested changes
Nov 25, 2024
| Ok(()) | ||
| assert_eq( | ||
| &conclusion[0], | ||
| &and_contents[args[0].as_integer().unwrap().to_usize().unwrap()], |
There was a problem hiding this comment.
By calling .as_integer().unwrap() here, we will panic if the argument is not an integer term. It would be better to return an error, with .as_integer_err()?:
Suggested change
| &and_contents[args[0].as_integer().unwrap().to_usize().unwrap()], | |
| &and_contents[args[0].as_integer_err()?.to_usize().unwrap()], |
Also, since we are simply accessing and_contents with [], this code will also panic if the index is out-of-bounds. It would be better to check that the argument value is in bounds, and return a nice error otherwise.
(The same thing applies to the other rules changed)
There was a problem hiding this comment.
Good points, thanks! I'll fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics of the rules
and,not_or,and_pos, andor_negchanged so that now they expect an argument as to the position in which the concluding element is from an n-ary application of the operatorsandoror.