Add Linter #42
Closed
Add Linter #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a linter to run on push
|
I will try to add something to lint the files before the push so that it passes these tests |
We can add pylint in later
|
I will put reopen when its ready |
|
I realized what I wanted was a prettier, which requires a precommit hook to avoid the ugly "auto formatted" commit messages clogging up the git history. |
|
After researching more, neither a precommit hook or a github prettier action will be a pleasant solution, best fix is to keep the linter, and edit the readme to teach people how to prettify and lint their code on their own end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a linter to run on push