-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme #106
Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @SamuelTrahanNOAA. So, if I'm understanding correctly, this problem/solution should be general for any non-run CCPP phase that has code setting errmsg/errflg within an openMP section. Do you know if there is any other code (e.g. in init/timestep_init) phases that are doing this that we need to fix, or is the problem confined to this code as far as you know?
I don't see any other OpenMP sections used in initialization. Perhaps I missed something in my grepping? As far as I know, no such bug remains. And, yes, this is completely general. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SamuelTrahanNOAA This looks great to me.
…to c3-pointer-fix
I've merged this PR into #102 since the UFS code managers plan to merge the two simultaneously. |
There were several bugs in the error detection in GFS_phys_time_vary.fv3.F90. Errors might go undetected, or may be reported incorrectly.
noahmptable.tbl
file is mandatory, even for configurations that don't need it. #107errflg=0
anderrmsg=''
in two routines that were missing them.