Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme #106

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented Sep 22, 2023

Copy link
Collaborator

@grantfirl grantfirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @SamuelTrahanNOAA. So, if I'm understanding correctly, this problem/solution should be general for any non-run CCPP phase that has code setting errmsg/errflg within an openMP section. Do you know if there is any other code (e.g. in init/timestep_init) phases that are doing this that we need to fix, or is the problem confined to this code as far as you know?

@SamuelTrahanNOAA
Copy link
Collaborator Author

I don't see any other OpenMP sections used in initialization. Perhaps I missed something in my grepping? As far as I know, no such bug remains.

And, yes, this is completely general.

Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamuelTrahanNOAA This looks great to me.

@SamuelTrahanNOAA
Copy link
Collaborator Author

I've merged this PR into #102 since the UFS code managers plan to merge the two simultaneously.

@SamuelTrahanNOAA SamuelTrahanNOAA changed the title Fix the broken error detection in GFS_phys_time_vary.fv3.F90 Fix the broken error detection in GFS_phys_time_vary.fv3.F90 and pointer issues in c3 scheme Sep 28, 2023
grantfirl added a commit that referenced this pull request Oct 3, 2023
Fixes to allow FV3_HRRR_c3 to run with gnu debug plus PR #113, #106, and #103
@grantfirl grantfirl merged commit e0a949d into ufs-community:ufs/dev Oct 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants