Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First reconciliation PR from production/RRFS.v1 #2449

Merged
merged 13 commits into from
Oct 18, 2024

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Oct 4, 2024

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

This PR is identical to #2147, but brings these changes from the production/RRFS.v1 branch to the develop branch instead.

Commit Message:

* UFSWM - physics updates for RRFS.v1 code freeze
  * FV3 - physics updates for RRFS.v1 code freeze
    * ccpp-physics - physics updates for RRFS.v1 code freeze
    

Priority:

  • High: Needed for SRW App

Git Tracking

UFSWM:

  • None

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • PR Updates/Changes Baselines.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • Gaea
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

@grantfirl
Copy link
Collaborator Author

@jkbk2004 @haiqinli I decided to start this PR by itself because the next PR that was merged into the production/RRFS.v1 branch has parts that may not be needed (that were a temporary solution to pass the -check all debug flag). That will require a bit of work on my part to see what of the next PR needs to be brought over to develop. In the meantime, we can at least start the process with this PR.

@grantfirl grantfirl marked this pull request as ready for review October 7, 2024 17:15
@grantfirl
Copy link
Collaborator Author

All pre-test RT failures are consistent with the physics code changes.

@jkbk2004
Copy link
Collaborator

@grantfirl we can start working on this pr. can you sync up branch?

@grantfirl
Copy link
Collaborator Author

@grantfirl we can start working on this pr. can you sync up branch?

@jkbk2004 OK, finished syncing.

@jkbk2004 jkbk2004 added Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked. labels Oct 14, 2024
@jkbk2004
Copy link
Collaborator

@FernandoAndrade-NOAA @BrianCurtis-NOAA We will skip Jet/Gaea/Derecho. Jet queue is too busy. Gaea C5 system upgrade continues. Derecho allocation is still not available.

@BrianCurtis-NOAA
Copy link
Collaborator

@FernandoAndrade-NOAA @BrianCurtis-NOAA We will skip Jet/Gaea/Derecho. Jet queue is too busy. Gaea C5 system upgrade continues. Derecho allocation is still not available.

I would recommend waiting for Gaea C5 to come back and be patient with Jet. Since I don't know the situation for the Derecho allocation, if we are still waiting on that by the time C5 comes back and Jet is done, then I think that would be OK at that point/situation.

@jkbk2004
Copy link
Collaborator

Jobs on Jet is not moving. @ulmononian @RatkoVasic-NOAA Gaea C5 system libraries are completed updated. An issue is created at #2472. @BrianCurtis-NOAA We need to skip Jet/Gaea/Derecho. What about acorn? I think we should merge this pr.

@BrianCurtis-NOAA
Copy link
Collaborator

Jobs on Jet is not moving. @ulmononian @RatkoVasic-NOAA Gaea C5 system libraries are completed updated. An issue is created at #2472. @BrianCurtis-NOAA We need to skip Jet/Gaea/Derecho. What about acorn? I think we should merge this pr.

@jkbk2004 I understand your situation is less than desirable given the priority of this PR in the community. I would still encourage you to be patient and resolve as many machine issues as you can. If the EPIC spack team can get a working spack-stack on the C5 upgrades ASAP, that would be a great push. Let's talk about Jet and Derecho at todays meeting as well.

Acorn was finished but I forgot to go grab the log before they started work, i'm going to try to see if i can get it, but i'll know by the meeting today if that's going to happen or not.

@ulmononian
Copy link
Collaborator

Jobs on Jet is not moving. @ulmononian @RatkoVasic-NOAA Gaea C5 system libraries are completed updated. An issue is created at #2472. @BrianCurtis-NOAA We need to skip Jet/Gaea/Derecho. What about acorn? I think we should merge this pr.

@jkbk2004 I understand your situation is less than desirable given the priority of this PR in the community. I would still encourage you to be patient and resolve as many machine issues as you can. If the EPIC spack team can get a working spack-stack on the C5 upgrades ASAP, that would be a great push. Let's talk about Jet and Derecho at todays meeting as well.

Acorn was finished but I forgot to go grab the log before they started work, i'm going to try to see if i can get it, but i'll know by the meeting today if that's going to happen or not.

fyi: spack-stack installation to accommodate c5 upgrade is ongoing (@RatkoVasic-NOAA).

@jkbk2004 jkbk2004 mentioned this pull request Oct 18, 2024
@jkbk2004
Copy link
Collaborator

Jet/Derecho are still not available. We will skip those machines. We can go ahead to merge this pr.

@jkbk2004
Copy link
Collaborator

@grantfirl new fv3 hash is NOAA-EMC/fv3atm@1e10d62

@jkbk2004 jkbk2004 requested a review from zach1221 October 18, 2024 15:12
@jkbk2004 jkbk2004 merged commit db1781a into ufs-community:develop Oct 18, 2024
4 checks passed
tsga added a commit to tsga/ufs-weather-model that referenced this pull request Oct 30, 2024
* develop:
  [develop]: Documentation updates + Submodule pointer update (fv3atm, ccpp-framework) for ccpp-framework PR 600 (bug fix for unit conversion error in ccpp_prebuild.py ) ufs-community#2464 + Update chunksizes for cubed sphere grid ufs-community#2465 (ufs-community#2463)
  First reconciliation PR from production/RRFS.v1 (ufs-community#2449)
  Add GFDL Land Model 4.0  (ufs-community#2146)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Baseline Updates Current baselines will be updated. Ready for Commit Queue The PR is ready for the Commit Queue. All checkboxes in PR template have been checked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants