Update accAPI.cpp to allow multiple uda servers connection #19
Conversation
retrieve the server host and port from environment to have a proper comaprison
source/client/accAPI.cpp
Outdated
| @@ -702,7 +702,7 @@ void putIdamServerPort(int port) | |||
| { | |||
| ENVIRONMENT* environment = getIdamClientEnvironment(); | |||
| int old_port = port; | |||
| environment->server_port = port; // UDA server service port number | |||
| environment->server_port = environment->server_port; // UDA server service port number | |||
There was a problem hiding this comment.
Surely this should be?
int old_port = environment->server_port;
environment->server_port = port;This code change is currently setting environment->server_port to itself?
There was a problem hiding this comment.
sure i was not fully wake up this mornign. thanks
|
I've incorporated these changes in the the release/2.8.0 branch. Please use this branch for any future testing. |
|
i found another issue...this one is a little bit tricky to solve but very annoying for us. if we have a new client (e.g. MINT) and two uda servers one new and one old then we can't get data because there is an issue with the protocol_version...which is not correct (as it assumes that the protocol_version is the same for everyone...it is for some reason a global static variable on the client side). |
we have added now the support on the client to allow multiple servers connections
|
commits done on our side to support multiple servers (including different versions), waiting for the build to check that things are ok |
we use signal_status to send some information to the client about on-going requests
|
This has been merged into release/2.8.0 |
retrieve the server host and port from environment to have a proper comaprison