Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding trelis dockerfile #702

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

shimwell
Copy link
Collaborator

@shimwell shimwell commented Jan 29, 2021

Proposed changes

This adds the dockerfile that helps users run the paramak with Trelis. This is based on the paramak dockerfile as a base while other versions have the openmc workshop. Not quite sure which one is better as the base but the paramak is a smaller repo. Usage instructions are in the Dockerfile

I should find a way of adding the license server info as a build arg

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@shimwell shimwell changed the base branch from develop to more_tally_scores January 29, 2021 23:42
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #702 (59b4e4e) into more_tally_scores (f785c07) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           more_tally_scores     #702   +/-   ##
==================================================
  Coverage              98.65%   98.65%           
==================================================
  Files                     68       68           
  Lines                   4324     4324           
==================================================
  Hits                    4266     4266           
  Misses                    58       58           
Impacted Files Coverage Δ
paramak/neutronics_utils.py 90.07% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f785c07...59b4e4e. Read the comment docs.

Base automatically changed from more_tally_scores to develop February 2, 2021 09:59
@shimwell shimwell marked this pull request as draft February 8, 2021 18:19
@shimwell
Copy link
Collaborator Author

shimwell commented Feb 8, 2021

Just converted to draft as it sounds like a trelis url is in the works at coreform and this would change things in the dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant