Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up LeapImage by copying textures on the render thread #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Speed up LeapImage by copying textures on the render thread #105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions Source/UltraleapTrackingCore/Private/LeapImage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ void FLeapImage::UpdateTextureRegions(UTexture2D* Texture, int32 MipIndex, uint3

void FLeapImage::UpdateTextureRegions(UTexture2D* Texture, const LEAP_IMAGE& Image, uint8* SrcData)
{
UpdateTextureRegions(Texture, 0, 1, &UpdateTextureRegion, Image.properties.width, Image.properties.bpp, SrcData, true);
UpdateTextureRegions(Texture, 0, 1, &UpdateTextureRegion, Image.properties.width, Image.properties.bpp, SrcData, false);
}

void FLeapImage::UpdateTextureOnGameThread(UTexture2D* Texture, uint8* SrcData, const int32 BufferLength)
Expand Down Expand Up @@ -156,21 +156,17 @@ void FLeapImage::OnImage(const LEAP_IMAGE_EVENT* ImageEvent)

if (OnImageCallback.IsBound())
{

UpdateTextureRegions(LeftImageTexture, LeftLeapImage, LeftImageBuffer.GetData());
UpdateTextureRegions(RightImageTexture, RightLeapImage, RightImageBuffer.GetData());

if (LeftImageTexture && RightImageTexture)
{
FLeapAsync::RunShortLambdaOnGameThread([&, BufferSize] {
if (bIsQuitting)
{
return;
}
// This is sufficient for now since leap images are small
UpdateTextureOnGameThread(LeftImageTexture, LeftImageBuffer.GetData(), BufferSize);
UpdateTextureOnGameThread(RightImageTexture, RightImageBuffer.GetData(), BufferSize);
bRenderDidUpdate = true;

// Todo: swap to optimized when ready
// UpdateTextureRegions(LeftImageTexture, LeftLeapImage, LeftImageBuffer.GetData());
// UpdateTextureRegions(RightImageTexture, RightLeapImage, RightImageBuffer.GetData());

OnImageCallback.Broadcast(LeftImageTexture, RightImageTexture);
});
Expand Down