VAULT 11 - Proxy Ollama Requests For Authentication #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodneyosodo
force-pushed
the
VAULT-11
branch
6 times, most recently
from
30f3d8a to
b35d7d1
Compare
rodneyosodo
changed the title
drasko
requested changes
Sep 11, 2024
proxy/handler.go
Outdated
| @@ -0,0 +1,88 @@ | |||
| package main | |||
There was a problem hiding this comment.
What is this?
Microservice must be done with go-kit, in the spirit of Magistrala microservices. Including metrics and logging.
rodneyosodo
force-pushed
the
VAULT-11
branch
from
b35d7d1 to
3f1b65d
Compare
drasko
requested changes
Sep 12, 2024
rodneyosodo
force-pushed
the
VAULT-11
branch
from
2bc848b to
45d7c47
Compare
Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
VAULT-11
branch
from
45d7c47 to
7ec21af
Compare
Signed-off-by: Rodney Osodo <[email protected]>
rodneyosodo
force-pushed
the
VAULT-11
branch
from
7ec21af to
73064ad
Compare
dborovcanin
requested changes
Sep 12, 2024
| COPY . . | ||
| RUN apk update \ | ||
| && apk add make upx\ | ||
| && make build \ |
There was a problem hiding this comment.
This won't work because a Git repo is in the root and is not copied to Docker context so build will net be able to fetch version from git.
proxy/docker/Dockerfile
Outdated
| @@ -0,0 +1,17 @@ | |||
| FROM golang:1.23-alpine AS builder | |||
There was a problem hiding this comment.
The version is lower than the one in go.mod.
Also update docker base image
dborovcanin
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature because it adds vault proxy a microservice to proxy requests for authentication
What does this do?
Adds vault proxy to proxy ollama request before forwarding the request to ollama
Which issue(s) does this PR fix/relate to?
Resolves #11
Resolves #9
Have you included tests for your changes?
Tested manually
Did you document any new/modified features?
Not yet
Notes
To be merged after #12