Merge pull request #1458 from umap-project/fix-datachanged

Make sure DataLayer._dataloaded is set only once all data is imported
umap-project · Dec 12, 2023 · 8ce09b0 · 8ce09b0
2 parents e84f5b1 + f54992c
commit 8ce09b0
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/umap/static/umap/js/umap.layer.js b/umap/static/umap/js/umap.layer.js
@@ -665,7 +665,6 @@ L.U.DataLayer = L.Evented.extend({
         this.backupOptions()
         this.fire('loaded')
         this._loading = false
-        this._dataloaded = true
       },
       context: this,
     })
@@ -674,6 +673,7 @@ L.U.DataLayer = L.Evented.extend({
   fromGeoJSON: function (geojson) {
     this.addData(geojson)
     this._geojson = geojson
+    this._dataloaded = true
     this.fire('dataloaded')
     this.fire('datachanged')
   },
@@ -730,7 +730,6 @@ L.U.DataLayer = L.Evented.extend({
       verb: 'GET',
       callback: (raw) => {
         this.clear()
-        this._dataloaded = true
         this.rawToGeoJSON(raw, this.options.remoteData.format, (geojson) =>
           this.fromGeoJSON(geojson)
         )