feat: open importers in a dialog instead of in the form #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yohanboniface
force-pushed
the
highlight-url-input
branch
from
6264782 to
ba3a1cc
Compare
Another step is needed to use this.elements instead of this.qs
The goal is to keep the form smaller, specifically to keep the submit button visible as much as possible.
yohanboniface
force-pushed
the
highlight-url-input
branch
from
ba3a1cc to
d99fe70
Compare
Let's make it simpler for new comers, and advanced users will know where to click to change the behaviour.
We are not really checking the validity of the form.
#2341) cf #2302 Warning: I removed the historic `width: 100%` on all buttons, who knows where this will break? :p Disabled:  Form valid: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #2302