feat: add a disabled/active mode to the submit button of import panel #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be interesting to use the JavaScript native API for that? https://developer.mozilla.org/en-US/docs/Learn/Forms/Form_validation#validating_forms_using_javascript The disabled state doesn't look disabled enough (visually) to me. @Aurelie-Jallut some advices/good practices about it? |
I'm not sure, given that in reality what we check here is the "validity" (consistency?) of the whole form, not the validity of each field/value. Maybe a naming issue of the |
Another step is needed to use this.elements instead of this.qs
The goal is to keep the form smaller, specifically to keep the submit button visible as much as possible.
Let's make it simpler for new comers, and advanced users will know where to click to change the behaviour.
yohanboniface
force-pushed
the
import-input-disabled
branch
from
3a8c29d to
2d80bd4
Compare
yohanboniface
force-pushed
the
highlight-url-input
branch
from
ba3a1cc to
d99fe70
Compare
|
Closed in favor of #2341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #2302
Warning: I removed the historic
width: 100%on all buttons, who knows where this will break? :pDisabled:
Form valid: