Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QR code icon #15540

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix QR code icon #15540

merged 1 commit into from
Feb 12, 2024

Conversation

rbottema
Copy link
Contributor

@rbottema rbottema commented Jan 8, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #15539

Description

Strips the width and height from the QR code SVG to ensure display is correct on all sizes. I used https://svgomg.net/ to optimize and minify the SVG. I promise I didn't change the actual QR code ;)

Old display in document type editor:
image

New:
image

To test: select icon-qr-code in document type editor and verify correct display.

Strips the width and height from the QR code SVG to ensure display is correct on all sizes. Used https://svgomg.net/ to optimize and minify the SVG.
Copy link

github-actions bot commented Jan 8, 2024

Hi there @rbottema, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp
Copy link
Contributor

mikecp commented Jan 8, 2024

Hello @rbottema

Thanks for this fix, it will look better indeed 👍
Someone form the team will have a look at it soon.

Cheers and Happy New Year!

@JasonElkin JasonElkin self-assigned this Jan 11, 2024
@nul800sebastiaan nul800sebastiaan merged commit 14be246 into umbraco:contrib Feb 12, 2024
14 checks passed
@nul800sebastiaan
Copy link
Member

Whoops... that is my bad! 😅 Thanks for the update @rbottema! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QR Code icon displays incorrectly
4 participants