Run the same cleanup with scaffolding content as when copying. #15541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new ContentScaffoldedNotification - Published the notification when a new scaffold has been created from a blueprint (content template) - Linked up the ComplextPEContent handler to do the same cleanup for the new notification as when copying. - registered handlers to the event for blocklist, blockgrid and nested content
Zeegaan
reviewed
Jan 10, 2024
|
Found one small thing before testing 😁 |
Co-authored-by: Nikolaj Geisle <[email protected]>
|
Looks good, tests good 🚀 |
This was referenced Jan 10, 2024
Zeegaan
pushed a commit
that referenced
this pull request
Jan 10, 2024
* Run the same cleanup with scaffolding content as when copying. - Added a new ContentScaffoldedNotification - Published the notification when a new scaffold has been created from a blueprint (content template) - Linked up the ComplextPEContent handler to do the same cleanup for the new notification as when copying. - registered handlers to the event for blocklist, blockgrid and nested content * PR pattern matching suggestion Co-authored-by: Nikolaj Geisle <[email protected]> --------- Co-authored-by: Sven Geusens <[email protected]> Co-authored-by: Nikolaj Geisle <[email protected]> (cherry picked from commit dff90c6)
bergmania
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Run the same cleanup with scaffolding content as when copying. - Added a new ContentScaffoldedNotification - Published the notification when a new scaffold has been created from a blueprint (content template) - Linked up the ComplextPEContent handler to do the same cleanup for the new notification as when copying. - registered handlers to the event for blocklist, blockgrid and nested content * PR pattern matching suggestion Co-authored-by: Nikolaj Geisle <[email protected]> --------- Co-authored-by: Sven Geusens <[email protected]> Co-authored-by: Nikolaj Geisle <[email protected]> (cherry picked from commit dff90c6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Issue: #14870
Description
Testing
See reproduction steps in linked issue #13698