Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clean xss from datatype name and alias. #15552

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

rammi987
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes #15529

Description

as this bug descript it #15529 create a new data type or edit an exiting one. Change name to something containing a / or :

What happens is, the / or : is replaced with a whitespace so "True / false" -> "True False" <- 3 whitespace.

When saving the datatype it runs a cleanForXss method witch replace / or : and other special chars with a whitespace.
I have removed the cleanforxss, to allow using the special chars to create names for the datatype.

Idon´t belive it makes a securtiy risk do to the fact that the rest of umbraco don´t do the same validation for the name property or alias. So in Doctype /: you name it is allowed, also due to the fact that the Datatype controller is behind the authizition.

Copy link

github-actions bot commented Jan 10, 2024

Hi there @rammi987, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link
Member

@nul800sebastiaan nul800sebastiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was definitely identified as a security concern back in 2015 so we can't just ignore that: c97617f

However, I can see that over the years we've loosened up the restrictions. I think that allowing / is perfectly fine, so is \. This can be added to the other exclusions already there. I don't think they need be part of the alias though, so only allow them in the datatype name.

@rammi987
Copy link
Contributor Author

@nul800sebastiaan Total fair about the cornces of c97617f i have instead of removing the CleanForXss add the / and \ to the ignoreFromClean argument list to the name, and not for the alias

@mikecp
Copy link
Contributor

mikecp commented Feb 10, 2024

HI @rammi987 ,

Thanks for this PR and for adding some accepted characters in the data type name 👍
It works as expected so let's merge it!

Cheers!

@mikecp mikecp merged commit 9e5eb2d into umbraco:contrib Feb 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving Data Type Removes Slash From Data Type Name
3 participants