Remove clean xss from datatype name and alias. #15552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes #15529
Description
as this bug descript it #15529 create a new data type or edit an exiting one. Change name to something containing a / or :
What happens is, the / or : is replaced with a whitespace so "True / false" -> "True False" <- 3 whitespace.
When saving the datatype it runs a cleanForXss method witch replace / or : and other special chars with a whitespace.
I have removed the cleanforxss, to allow using the special chars to create names for the datatype.
Idon´t belive it makes a securtiy risk do to the fact that the rest of umbraco don´t do the same validation for the name property or alias. So in Doctype /: you name it is allowed, also due to the fact that the Datatype controller is behind the authizition.