Fix: No Blocks Mode for RTE when required context for Blocks is not present #15556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOvergaard
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Tested on a custom dashboard using <umb-property> with the same model that was in the original issue description and it works. I can see a rich text editor without the blocks button. Pasting in the custom block markup doesn't let the block show up either and no errors are thrown if the block markup is accidentally left in the html.
LGTM!
|
LGTM 🚀 |
|
Thanks for fixing this. It's also affecting Rich Text Areas inside DocTypeGridEditor documents and has blocked us deploying an upgrade to Umbraco 13. Now we can continue when released :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To continue supporting Rich Text Editor Property Editor implemented via
<umb-property>without any further Backoffice implementations in its surroundings, this PR introduces a No Blocks Mode that will be active when the requirements for Blocks aren't meet.Fixes #15474