-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V15: Show server configuration when configuring the Upload Field #18185
Open
iOvergaard
wants to merge
46
commits into
v15/dev
Choose a base branch
from
v15/feature/dropzone-allowed-types
base: v15/dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mick the OpenAPI generator
…cate upload status
… able to show the progress in percent
…re/temporary-file-configuration
…ary-file-configuration
…function.ts Co-authored-by: Lee Kelleher <[email protected]>
iOvergaard
added
category/ux
User experience
type/feature
area/frontend
release/15.3.0
category/dx
Developer experience
and removed
category/ux
User experience
labels
Jan 31, 2025
iOvergaard
changed the title
V15/feature/dropzone allowed types
V15: Show server configuration when configuring the Upload Field
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a notice and validation to the data type configuration of Upload Field to notify the CMS developer about the effects of the current server configuration on the Accepted file extensions on the Upload Field. For good measure, we also mention the maximum file size in the notice, even though it does not affect the extensions. This is to help the developer understand all of the limitations at once.
The server allows setting
Content::AllowedUploadedFileExtensions
andContent::DisallowedUploadedFileExtensions
, which can have an inverse effect on the configured Accepted file extensions on the Upload Field. You may end up in a situation where you allow too much on the client that will then ultimately end up being denied on the server.The CMS developer is first notified of potential conflicts with the server. Note, however, if the server only disallows certain types, as in the example above, you can set whatever you want in the accepted types below.
If you type one of the disallowed extensions in the field, you will now be prevented from saving:
To accomplish this, I have created a new property editor UI called "Accepted Types" that extends the multiple text string editor. This type adds its validation based on the newly created UmbTemporaryFileConfigRepository.
How to test