Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V15 Added acceptance tests for the block with RTE in a Content #18301

Open
wants to merge 7 commits into
base: v15/hotfix/nested-rte-partial-variancy
Choose a base branch
from

Reverted

5edd320
Select commit
Loading
Failed to load commit list.
Open

V15 Added acceptance tests for the block with RTE in a Content #18301

Reverted
5edd320
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v15/hotfix/nested-rte-partial-variancy) failed Feb 13, 2025 in 28s

CodeScene PR Check

Quality Gate Failed

Gates Failed
New code is healthy (1 new file with code health below 9.00)
Enforce advisory code health rules (2 files with Code Duplication)

Gates Passed
2 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
New code is healthy Violations Code Health Impact
ContentWithBlockGrid.spec.ts 1 rule 10.00 → 8.55 Suppress
Enforce advisory code health rules Violations Code Health Impact
ContentWithBlockGrid.spec.ts 1 advisory rule 10.00 → 8.55 Suppress
ContentWithBlockList.spec.ts 1 advisory rule 10.00 → 9.10 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Code Duplication ContentWithBlockGrid.spec.ts
  • Code Duplication ContentWithBlockList.spec.ts

Annotations

Check warning on line 447 in tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithBlockGrid.spec.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/hotfix/nested-rte-partial-variancy)

❌ New issue: Code Duplication

The module contains 15 functions with similar structure: 'can add an invariant block element with RTE TinyMCE in the content','can add an invariant block element with RTE Tiptap in the content','can add an variant block element with an invariant RTE TinyMCE in the content','can add an variant block element with an invariant RTE Tiptap in the content' and 11 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.

Check warning on line 395 in tests/Umbraco.Tests.AcceptanceTest/tests/DefaultConfig/Content/ContentWithBlockList.spec.ts

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v15/hotfix/nested-rte-partial-variancy)

❌ New issue: Code Duplication

The module contains 10 functions with similar structure: 'can add an invariant block element with RTE TinyMCE in the content','can add an invariant block element with RTE Tiptap in the content','can add an variant block element with an invariant RTE TinyMCE in the content','can add an variant block element with an invariant RTE Tiptap in the content' and 6 more functions. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.