Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cosmos-sdk to v0.47.15 #2646

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: update cosmos-sdk to v0.47.15 #2646

merged 1 commit into from
Dec 17, 2024

Conversation

gsk967
Copy link
Collaborator

@gsk967 gsk967 commented Dec 17, 2024

Description

closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Summary by CodeRabbit

  • New Features

    • Updated to version 6.7.2 with enhancements and fixes.
    • Price Feeder updated to version umee/2.4.4+.
  • Improvements

    • Upgraded cosmos-sdk to version 0.47.15.
    • Dependency upgrades noted.
  • Bug Fixes

    • Resolved issues with the max_withdraw query.
  • Documentation

    • Updated release notes with upgrade instructions and requirements for libwasmvm v1.5.5.

@gsk967 gsk967 requested a review from a team as a code owner December 17, 2024 10:50
Copy link
Contributor

coderabbitai bot commented Dec 17, 2024

Walkthrough

This pull request introduces version 6.7.2 of the Umee network software. The changes include updating the cosmos-sdk to version 0.47.15, fixing the max_withdraw query, and upgrading dependencies. The release notes specify a new Price Feeder version (umee/2.4.4+) and a requirement for libwasmvm v1.5.5. The upgrade process involves registering a new upgrade handler in the app/upgrades.go file, following the existing pattern of version-specific upgrade registrations.

Changes

File Change Summary
CHANGELOG.md - Added version v6.7.2
- Added dependency upgrade entry
- Added cosmos-sdk update to v0.47.15
- Added max_withdraw query fix
RELEASE_NOTES.md - Updated version to v6.7.2
- Updated Price Feeder to umee/2.4.4+
- Updated libwasmvm requirement to v1.5.5
app/upgrades.go - Added RegisterUpgradeHandlers() method
- Added upgrade registration methods for v6.6RC1, v6.4, and v6.0
- Updated upgrade registration for v6.7.2

Sequence Diagram

sequenceDiagram
    participant App as UmeeApp
    participant UpgradeHandler as Upgrade Handler
    participant StoreUpgrade as Store Upgrade

    App->>UpgradeHandler: Register Upgrade for v6.7.2
    UpgradeHandler->>StoreUpgrade: Prepare Store Migrations
    StoreUpgrade-->>UpgradeHandler: Store Upgrade Complete
    UpgradeHandler-->>App: Upgrade Registration Successful
Loading

Possibly related PRs

Suggested labels

T:Dependencies, A:Automerge

Suggested reviewers

  • abdulgig

Poem

🐰 Hop, hop, upgrade we go!
Version 6.7.2 starts to grow
Cosmos-sdk dancing light
Max_withdraw query shining bright
Umee network leaps with glee! 🚀

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request. We would love to hear your feedback on Discord.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b2b6f4 and 3abaf55.

📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • RELEASE_NOTES.md (1 hunks)
  • app/upgrades.go (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • RELEASE_NOTES.md
🔇 Additional comments (2)
app/upgrades.go (1)

59-59: LGTM: Straightforward upgrade registration

The registration for v6.7.2 follows the established pattern and correctly uses nil handlers since this is primarily a dependency update.

CHANGELOG.md (1)

47-57: LGTM: Well-structured changelog entry

The changelog entry for v6.7.2 follows the standard format and properly documents:

  • Dependency upgrades under Improvements
  • The cosmos-sdk update and max_withdraw query fix under Bug Fixes with correct PR references

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.01%. Comparing base (7f05ad4) to head (3abaf55).
Report is 559 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2646       +/-   ##
===========================================
- Coverage   75.38%   62.01%   -13.38%     
===========================================
  Files         100      275      +175     
  Lines        8025    19629    +11604     
===========================================
+ Hits         6050    12172     +6122     
- Misses       1589     6685     +5096     
- Partials      386      772      +386     
Files with missing lines Coverage Δ
app/upgrades.go 44.72% <100.00%> (ø)

... and 216 files with indirect coverage changes

@gsk967 gsk967 enabled auto-merge December 17, 2024 13:55
@gsk967 gsk967 disabled auto-merge December 17, 2024 13:58
@gsk967 gsk967 merged commit 14b0e03 into main Dec 17, 2024
24 of 28 checks passed
@gsk967 gsk967 deleted the sai/v6.7.2 branch December 17, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants