Tipdetection #676
Open
Tipdetection #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git push
Open
qhdwight
force-pushed
the
integration
branch
4 times, most recently
from
30aea7d
to
6d06b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #675
What features did you add, bugs did you fix, etc?
Added tip detection for the rover using TF tree data
Did you add documentation to the wiki?
No (If not explain why not)
Will do later
How was this code tested?
Summarize how you tested this code. Your objective here is to prove to the reviewers that this code actually works without them having to run it themselves. It is often helpful to include screenshots, tables, graphs, and/or a short write-up of testing procedures. Results can be either from sim, the robot, or both depending on what you think is sufficient for the feature you added.
Tested in the sim, manually making the rover tip over and seeing when the code returned true(that it is tipping). Also tested with the rover running by itself, into a tipping predicament to see when it reported itself to be tipping.
Did you test this in sim?
Yes
Did you test this on the rover?
No
Did you add unit tests?
No (If not explain why not)