Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

[feature request] Criar página de submissões #101

Merged
merged 16 commits into from
Dec 1, 2023

Conversation

LuizaMaluf
Copy link
Collaborator

@LuizaMaluf LuizaMaluf commented Nov 28, 2023

O que este PR introduz?

Close #100

Checklist

Por favor, cheque se seu PR atende aos seguintes requisitos:

  • Eu atualizei a documentação de acordo (se necessário).
  • Eu adicionei testes para cobrir minhas mudanças (se necessário).
  • Todos os novos e existentes testes passaram.
  • Meu código segue o estilo de código deste projeto.

Tipo de PR

Que tipo de mudança este PR introduz?

  • Correção de bug
  • Feature request
  • Atualização na documentação
  • Atualização no estilo do código (formatação, variáveis locais, etc.)
  • Refatoração (sem mudanças funcionais, sem mudanças na API)
  • Atualizações de dependências
  • Mudanças relacionadas a CI/CD
  • Chore (mudanças não relacionadas a código)
  • Mudanças relacionadas a build (e.g. Dockerfile, pyproject.toml, etc.)

Este PR introduz uma mudança que quebra a compatibilidade?

  • Sim
  • Não

Outras informações (screenshots, detalhes, etc.)

@LuizaMaluf LuizaMaluf added feature request New feature request. review needed This PR will be reviewed in the future. tests needed Need to add tests for this feature or bug. labels Nov 28, 2023
@LuizaMaluf LuizaMaluf added this to the Sprint 06 milestone Nov 28, 2023
@LuizaMaluf LuizaMaluf self-assigned this Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3bc85bb) 100.00% compared to head (bc49bd8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #101   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        40    +2     
  Lines          452       468   +16     
=========================================
+ Hits           452       468   +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr November 28, 2023 13:50 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr November 29, 2023 11:27 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr November 29, 2023 11:47 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr November 29, 2023 13:24 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr November 29, 2023 13:28 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr November 29, 2023 14:24 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr November 30, 2023 23:45 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr November 30, 2023 23:48 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr December 1, 2023 11:16 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr December 1, 2023 13:36 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr December 1, 2023 14:05 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr December 1, 2023 14:18 Inactive
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr December 1, 2023 16:30 Inactive
Copy link
Contributor

@bitterteriyaki bitterteriyaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Só essa pequena coisinha para deixar o código visualmente melhor. Ótimo código!

apps/submissions/tests.py Outdated Show resolved Hide resolved
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr December 1, 2023 17:23 Inactive
apps/submissions/tests.py Outdated Show resolved Hide resolved
@bitterteriyaki bitterteriyaki removed the tests needed Need to add tests for this feature or bug. label Dec 1, 2023
@bitterteriyaki bitterteriyaki temporarily deployed to unb-mds-feature-submiss-zqj2wr December 1, 2023 18:24 Inactive
Copy link
Contributor

@bitterteriyaki bitterteriyaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TYVM.

@bitterteriyaki bitterteriyaki merged commit d8b21ab into main Dec 1, 2023
5 checks passed
@bitterteriyaki bitterteriyaki deleted the feature/submission-page branch December 1, 2023 20:12
@LuizaMaluf LuizaMaluf restored the feature/submission-page branch December 7, 2023 00:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request New feature request. review needed This PR will be reviewed in the future.
Projects
Status: ✅ Feito
Development

Successfully merging this pull request may close these issues.

[feature request] Criar página de submissões
2 participants