Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

[feature request] Desenvolvimento dos testes #57

Merged
merged 25 commits into from
Nov 8, 2023
Merged

[feature request] Desenvolvimento dos testes #57

merged 25 commits into from
Nov 8, 2023

Conversation

LuizaMaluf
Copy link
Collaborator

@LuizaMaluf LuizaMaluf commented Nov 1, 2023

O que este PR introduz?

Closes #30.

  • apps.problems
  • apps.users
  • apps.contests

Checklist

Por favor, cheque se seu PR atende aos seguintes requisitos:

  • Eu atualizei a documentação de acordo (se necessário).
  • Eu adicionei testes para cobrir minhas mudanças (se necessário).
  • Todos os novos e existentes testes passaram.
  • Meu código segue o estilo de código deste projeto.

Tipo de PR

Que tipo de mudança este PR introduz?

  • Correção de bug
  • Feature request
  • Atualização na documentação
  • Atualização no estilo do código (formatação, variáveis locais, etc.)
  • Refatoração (sem mudanças funcionais, sem mudanças na API)
  • Atualizações de dependências
  • Mudanças relacionadas a CI/CD
  • Chore (mudanças não relacionadas a código)
  • Mudanças relacionadas a build (e.g. Dockerfile, pyproject.toml, etc.)

Este PR introduz uma mudança que quebra a compatibilidade?

  • Sim
  • Não

Outras informações (screenshots, detalhes, etc.)

@LuizaMaluf LuizaMaluf changed the title Tests Desenvolvimento dos testes Nov 1, 2023
@LuizaMaluf LuizaMaluf added the review needed This PR will be reviewed in the future. label Nov 1, 2023
@LuizaMaluf LuizaMaluf added this to the Sprint 3 milestone Nov 1, 2023
@bitterteriyaki bitterteriyaki changed the title Desenvolvimento dos testes [feature request] Desenvolvimento dos testes Nov 1, 2023
@bitterteriyaki bitterteriyaki self-requested a review November 1, 2023 11:31
@bitterteriyaki bitterteriyaki marked this pull request as draft November 1, 2023 11:31
@bitterteriyaki bitterteriyaki added feature request New feature request. tests needed Need to add tests for this feature or bug. labels Nov 1, 2023
apps/users/tests_users.py Outdated Show resolved Hide resolved
apps/users/tests_users.py Outdated Show resolved Hide resolved
apps/contests/tests_contests.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
apps/contests/tests.py 100.00% <100.00%> (ø)
apps/problems/tests.py 100.00% <100.00%> (ø)
apps/users/tests.py 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

Copy link

codeclimate bot commented Nov 8, 2023

Code Climate has analyzed commit 38f3091 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 5

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.8% (19.7% change).

View more on Code Climate.

@bitterteriyaki bitterteriyaki marked this pull request as ready for review November 8, 2023 13:01
Copy link
Contributor

@bitterteriyaki bitterteriyaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bitterteriyaki bitterteriyaki merged commit 4d0d29f into main Nov 8, 2023
4 checks passed
@bitterteriyaki bitterteriyaki deleted the tests branch November 8, 2023 13:03
@bitterteriyaki bitterteriyaki removed review needed This PR will be reviewed in the future. tests needed Need to add tests for this feature or bug. labels Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature request New feature request.
Projects
Status: ✅ Feito
Development

Successfully merging this pull request may close these issues.

[tests] Começar o desenvolvimento de testes unitários
3 participants