Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

[bug] Adicionar validadores em todas as páginas de admin #76

Merged
merged 20 commits into from
Nov 15, 2023

Conversation

LuizaMaluf
Copy link
Collaborator

@LuizaMaluf LuizaMaluf commented Nov 14, 2023

O que este PR introduz?

Closes #27.

Checklist

Por favor, cheque se seu PR atende aos seguintes requisitos:

  • Eu atualizei a documentação de acordo (se necessário).
  • Eu adicionei testes para cobrir minhas mudanças (se necessário).
  • Todos os novos e existentes testes passaram.
  • Meu código segue o estilo de código deste projeto.

Tipo de PR

Que tipo de mudança este PR introduz?

  • Correção de bug
  • Feature request
  • Atualização na documentação
  • Atualização no estilo do código (formatação, variáveis locais, etc.)
  • Refatoração (sem mudanças funcionais, sem mudanças na API)
  • Atualizações de dependências
  • Mudanças relacionadas a CI/CD
  • Chore (mudanças não relacionadas a código)
  • Mudanças relacionadas a build (e.g. Dockerfile, pyproject.toml, etc.)

Este PR introduz uma mudança que quebra a compatibilidade?

  • Sim
  • Não

Outras informações (screenshots, detalhes, etc.)

@LuizaMaluf LuizaMaluf added the bug A bug with the application. label Nov 14, 2023
@LuizaMaluf LuizaMaluf self-assigned this Nov 14, 2023
@LuizaMaluf LuizaMaluf changed the title feat(validators): contest admin form validator [feature request](validators): contest admin form validator Nov 14, 2023
@LuizaMaluf LuizaMaluf changed the title [feature request](validators): contest admin form validator [feature request]: adicionar validadores em todas as páginas de admin Nov 14, 2023
Copy link

codecov bot commented Nov 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (86cb1cd) 97.18% compared to head (94b99cf) 95.42%.
Report is 12 commits behind head on main.

❗ Current head 94b99cf differs from pull request most recent head 1d1de6d. Consider uploading reports for the commit 1d1de6d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   97.18%   95.42%   -1.76%     
==========================================
  Files          32       29       -3     
  Lines         497      306     -191     
==========================================
- Hits          483      292     -191     
  Misses         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitterteriyaki bitterteriyaki changed the title [feature request]: adicionar validadores em todas as páginas de admin [feature request] Adicionar validadores em todas as páginas de admin Nov 15, 2023
@bitterteriyaki bitterteriyaki added the review needed This PR will be reviewed in the future. label Nov 15, 2023
LuizaMaluf and others added 11 commits November 14, 2023 22:12
feat(validators): contest admin form validator - fix errors

feat(validators): contest admin form validator - fix errors.2

feat(validators): contest admin form validator - fix errors.3

feat(validators): contest admin form validator test
feat(validators): contest status form validator tests

feat(validators): contest status form validator tests

feat(validators): contest status form validator tests
fix(templates/registration): remove unecessary code
@bitterteriyaki bitterteriyaki force-pushed the feature/validators-forms branch from 221baf2 to 8188fbc Compare November 15, 2023 01:13
@bitterteriyaki bitterteriyaki added this to the Sprint 4 milestone Nov 15, 2023
Copy link
Contributor

@bitterteriyaki bitterteriyaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, TYVM.

Copy link

codeclimate bot commented Nov 15, 2023

Code Climate has analyzed commit 1d1de6d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 95.4% (-1.6% change).

View more on Code Climate.

@bitterteriyaki bitterteriyaki merged commit b65835f into main Nov 15, 2023
2 checks passed
@bitterteriyaki bitterteriyaki deleted the feature/validators-forms branch November 15, 2023 12:14
@bitterteriyaki bitterteriyaki removed the review needed This PR will be reviewed in the future. label Nov 15, 2023
@bitterteriyaki bitterteriyaki changed the title [feature request] Adicionar validadores em todas as páginas de admin [bug] Adicionar validadores em todas as páginas de admin Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A bug with the application.
Projects
Status: ✅ Feito
Development

Successfully merging this pull request may close these issues.

[bug] Adicionar validadores em todos os formulários na página de administração
4 participants