feat: update download jwt button verify page #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from 3e43a07 |
|
@ldhyen99, what's the status of this? |
It can be reviewed now. |
|
Hi @namhoang1604 for the discuss in yesterday, after checking the code, I think we should to decode in because we use the decode data in some place in our code: In JsonBlock, we need to decode data to display on the UI Should we be flexible in renderer? We will need more steps to pass the decode JWT for only render while could use data that has been decode |
|
@ldhyen99 I think we need to add the decodedEnvelopedVC to the prop of the component |
packages/mock-app/src/components/CredentialTabs/CredentialTabs.tsx
Outdated
Show resolved
Hide resolved
huynguyen-hl
previously approved these changes
Oct 25, 2024
Signed-off-by: Nam Hoang <[email protected]>
Code Coverage Report
|
…/github.com/uncefact/tests-untp into feat/update_download_jwt_button_verify_page
huynguyen-hl
approved these changes
Nov 1, 2024
namhoang1604
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add a "Download JWT" button inline with the existing tab navigation (outside of the tabs themselves), allowing users to download the full JWT.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
UI Desktop
UI mobile
Data after downloading VC
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?