chore: pass headers to request #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashleythedeveloper
requested review from
ldhyen99,
namhoang1604 and
huynguyen-hl
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by 🧪jest coverage report action from 9d6d775 |
ashleythedeveloper
force-pushed
the
chore/pass_headers_to_request
branch
from
7377735
to
b813270
Compare
ldhyen99
reviewed
Oct 24, 2024
packages/vc-test-suite/tests/RenderTemplate2024/render-template-2024.test.ts
Outdated
Show resolved
Hide resolved
ashleythedeveloper
force-pushed
the
chore/pass_headers_to_request
branch
from
b813270
to
9d6d775
Compare
ldhyen99
previously approved these changes
Oct 29, 2024
namhoang1604
force-pushed
the
chore/pass_headers_to_request
branch
from
9d6d775
to
e86b623
Compare
Code Coverage Report
|
namhoang1604
previously approved these changes
Oct 29, 2024
huynguyen-hl
previously approved these changes
Oct 29, 2024
Signed-off-by: Nam Hoang <[email protected]>
namhoang1604
dismissed stale reviews from huynguyen-hl, ldhyen99, and themself
via
f0e9ac6
ldhyen99
reviewed
Oct 30, 2024
namhoang1604
approved these changes
Oct 30, 2024
huynguyen-hl
approved these changes
Oct 30, 2024
ldhyen99
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR adds the ability to pass custom headers to requests across the tier 1 test suite. This update allows users to specify headers such as authorization tokens in the configuration, making the test suites more flexible when interacting with services that require specific HTTP headers.
It also includes relevant documentation updates and test cases to validate this new feature, ensuring headers are plain objects and that they are passed correctly in requests.
NOTE: It has been uncovered that the render tests are failing. This was hidden due to the authorisation error this PR seeks to resolve. Another PR will be raised to fix the tests.
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?