Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dpp render template 0.5.0 #132

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Conversation

huynguyen-hl
Copy link
Contributor

@huynguyen-hl huynguyen-hl commented Oct 23, 2024

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This is a Handlebar template that accurately reflects the new v0.5 DPP design.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Mobile UI:
image
image
image
image

Desktop UI:
image
image
image
image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

Copy link

Coverage report

St.❔
Category Percentage Covered / Total
🟒 Statements 100% 0/0
🟒 Branches 100% 0/0
🟒 Functions 100% 0/0
🟒 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by πŸ§ͺjest coverage report action from 623953e

@ldhyen99
Copy link
Contributor

Hi, can you check again this UI on the desktop
image

I see in UI, which after "by" it should be in one line
image

@ldhyen99
Copy link
Contributor

Should we put this text on one line?
image

image

@ldhyen99
Copy link
Contributor

Can you help me check the History block? I can not see any data on credentialSubject.traceabilityInformation when using https://jargon.sh/user/unece/DigitalProductPassport/v/0.5.0/artefacts/jsonSchemas/DigitalProductPassport_instance.json?class=DigitalProductPassport_instance

image

The UI:
image

Thanks

@ldhyen99
Copy link
Contributor

Should we format date following the design?
image

The UI
image

@ldhyen99
Copy link
Contributor

Hi, can you add the ">" in Product composition
image

as the design
image

@huynguyen-hl
Copy link
Contributor Author

@ldhyen99

Hi, can you check again this UI on the desktop image

I see in UI, which after "by" it should be in one line image

This was my mistake when implementing the UI. I’ve already fixed it in the latest commit. Thanks for pointing it out.


Should we put this text on one line? image

image

Since your text is a bit long, it will move to the next line. I’ll adjust the text-decoration to fit the text length. Thanks for bringing this up.


Can you help me check the History block? I can not see any data on credentialSubject.traceabilityInformation when using https://jargon.sh/user/unece/DigitalProductPassport/v/0.5.0/artefacts/jsonSchemas/DigitalProductPassport_instance.json?class=DigitalProductPassport_instance

image The UI: image

Thanks

This was my error when implementing this UI. The designer and I didn’t realize that the data model had changed. I’ll update the data mapping for this UI accordingly. Thanks for raising this.


Should we format date following the design? image

The UI image

I don’t believe we can format dates directly in a Handlebars (hbs) template, as it doesn’t support that feature. To my knowledge, there isn’t a solution for formatting dates in an hbs template. If you have any ideas, please feel free to share, I’d appreciate it. Thanks for bringing this up.


Hi, can you add the ">" in Product composition image

as the design image

This is from an older design. We discussed it in this conversation: https://gosource.slack.com/archives/C05R3FRGA3U/p1729236646889239?thread_ts=1729158343.107749&cid=C05R3FRGA3U.

The DPP design hasn’t been updated to reflect this conversation.

Copy link

github-actions bot commented Oct 29, 2024

Code Coverage Report

Lines Statements Branches Functions
Coverage: 79%
77.72% (2715/3493) 62.33% (518/831) 74.09% (306/413)
Title Lines Statements Branches Functions
All packages Coverage: 79%
77.72% (2715/3493) 62.33% (518/831) 74.09% (306/413)
Components Coverage: 85%
84.85% (510/601) 73.75% (118/160) 77.04% (94/122)
Mock app Coverage: 68%
69.18% (348/503) 48.41% (61/126) 67.56% (75/111)
Services Coverage: 75%
70.62% (880/1246) 52.6% (202/384) 75% (96/128)
UNTP test suite Coverage: 57%
57.78% (991/1715) 82.53% (137/166) 71.92% (41/57)
VC test suite Coverage: 6%
5.85% (12/205) 4.34% (2/46)

@huynguyen-hl huynguyen-hl merged commit a1deac5 into next Oct 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants