-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dpp render template 0.5.0 #132
Conversation
Coverage report
Test suite run success0 tests passing in 0 suite. Report generated by π§ͺjest coverage report action from 623953e |
Can you help me check the History block? I can not see any data on credentialSubject.traceabilityInformation when using https://jargon.sh/user/unece/DigitalProductPassport/v/0.5.0/artefacts/jsonSchemas/DigitalProductPassport_instance.json?class=DigitalProductPassport_instance Thanks |
This was my mistake when implementing the UI. Iβve already fixed it in the latest commit. Thanks for pointing it out.
Since your text is a bit long, it will move to the next line. Iβll adjust the text-decoration to fit the text length. Thanks for bringing this up.
This was my error when implementing this UI. The designer and I didnβt realize that the data model had changed. Iβll update the data mapping for this UI accordingly. Thanks for raising this. I donβt believe we can format dates directly in a Handlebars (hbs) template, as it doesnβt support that feature. To my knowledge, there isnβt a solution for formatting dates in an hbs template. If you have any ideas, please feel free to share, Iβd appreciate it. Thanks for bringing this up. This is from an older design. We discussed it in this conversation: https://gosource.slack.com/archives/C05R3FRGA3U/p1729236646889239?thread_ts=1729158343.107749&cid=C05R3FRGA3U. The DPP design hasnβt been updated to reflect this conversation. |
What type of PR is this? (check all applicable)
Description
This is a Handlebar template that accurately reflects the new v0.5 DPP design.
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Mobile UI:
Desktop UI:
Added tests?
Added to documentation?