Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TE render template 0.5.0 #137

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Conversation

huynguyen-hl
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This is a Handlebar template that accurately reflects the new v0.5 TE design.

Mobile & Desktop Screenshots/Recordings

image image image image image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

Copy link

Coverage report

St.❔
Category Percentage Covered / Total
🟒 Statements 100% 0/0
🟒 Branches 100% 0/0
🟒 Functions 100% 0/0
🟒 Lines 100% 0/0

Test suite run success

0 tests passing in 0 suite.

Report generated by πŸ§ͺjest coverage report action from a60d79f

namhoang1604
namhoang1604 previously approved these changes Oct 29, 2024
@ldhyen99
Copy link
Contributor

ldhyen99 commented Oct 29, 2024

In Sensor type, what's the label of the text (Link or Type information)?
image

Should we confirm with the design about the label?
image

Copy link

github-actions bot commented Oct 29, 2024

Code Coverage Report

Lines Statements Branches Functions
Coverage: 79%
77.46% (2706/3493) 61.86% (511/826) 74.09% (306/413)
Title Lines Statements Branches Functions
All packages Coverage: 79%
77.46% (2706/3493) 61.86% (511/826) 74.09% (306/413)
Components Coverage: 85%
84.85% (510/601) 73.75% (118/160) 77.04% (94/122)
Mock app Coverage: 68%
69.18% (348/503) 48.41% (61/126) 67.56% (75/111)
Services Coverage: 75%
70.62% (880/1246) 52.6% (202/384) 75% (96/128)
UNTP test suite Coverage: 57%
57.25% (982/1715) 80.74% (130/161) 71.92% (41/57)
VC test suite Coverage: 6%
5.85% (12/205) 4.34% (2/46)

@DenicaGo
Copy link

Good spotting. Accidental inconsistency on my part. The link should read "Type information".

@huynguyen-hl huynguyen-hl merged commit 9345412 into next Oct 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants