Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support array for traceability event and existing events #144

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

namhoang1604
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR adds processTraceabilityEvent function and the convertObjectToArray1Item function to support the existing event using the data from JSON form to issue an array credentialSubject.
Example flow for Object Event

flowchart TD
   A[Client] --JSON form radio button select an event--> B[Traceability Event]
   B --An array data--> C[Object Event]
   A --JSON form simple Object event--> D[Convert object data to array 1 item data]
   D --An array of 1 Object event data--> C
Loading

Related Tickets & Documents

https://github.com/gs-gs/fa-ag-trace/issues/627

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ“• documentation
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

github-actions bot commented Nov 1, 2024

Code Coverage Report

Lines Statements Branches Functions
Coverage: 80%
80.03% (2746/3431) 66.33% (526/793) 73.84% (305/413)
Title Lines Statements Branches Functions
All packages Coverage: 80%
80.03% (2746/3431) 66.33% (526/793) 73.84% (305/413)
Components Coverage: 85%
84.85% (510/601) 73.75% (118/160) 77.04% (94/122)
Mock app Coverage: 68%
69.18% (348/503) 48.41% (61/126) 67.56% (75/111)
Services Coverage: 79%
76.92% (910/1183) 60.69% (210/346) 74.21% (95/128)
UNTP test suite Coverage: 57%
57.78% (991/1715) 82.53% (137/166) 71.92% (41/57)
VC test suite Coverage: 6%
5.85% (12/205) 4.34% (2/46)

@namhoang1604 namhoang1604 merged commit 44f3df8 into next Nov 1, 2024
1 check passed
@namhoang1604 namhoang1604 deleted the feat/traceability-event branch November 1, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants