Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docs build #146

Merged
merged 1 commit into from
Nov 1, 2024
Merged

fix: docs build #146

merged 1 commit into from
Nov 1, 2024

Conversation

ashleythedeveloper
Copy link
Collaborator

@ashleythedeveloper ashleythedeveloper commented Nov 1, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Description

This PR fixes documentation build issues. Changes include:

  1. Added a new GitHub Actions workflow job build_docs to ensure the docs can be built
  2. Fixed table formatting in markdown files to properly escape special characters

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Screenshot 2024-11-01 at 4 01 20 PM Screenshot 2024-11-01 at 4 12 23 PM

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📕 storybook
  • 🙅 no documentation needed

@ashleythedeveloper ashleythedeveloper self-assigned this Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Code Coverage Report

Lines Statements Branches Functions
Coverage: 79%
 77.51% (2716/3504) 61.84% (517/836) 74.21% (308/415)
Title Lines Statements Branches Functions
All packages Coverage: 79%
 77.51% (2716/3504) 61.84% (517/836) 74.21% (308/415)
Components Coverage: 85%
 84.85% (510/601) 73.75% (118/160) 77.04% (94/122)
Mock app Coverage: 69%
 69.59% (357/513) 49.26% (67/136) 67.85% (76/112)
Services Coverage: 75%
 70.64% (881/1247) 52.6% (202/384) 75.19% (97/129)
UNTP test suite Coverage: 57%
 57.25% (982/1715) 80.74% (130/161) 71.92% (41/57)
VC test suite Coverage: 8%
 7.69% (12/156) 7.4% (2/27)

@ashleythedeveloper ashleythedeveloper merged commit dd8b307 into next Nov 1, 2024
2 checks passed
@ashleythedeveloper ashleythedeveloper deleted the fix/docs_build branch November 1, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namhoang1604 namhoang1604 namhoang1604 approved these changes

@huynguyen-hl huynguyen-hl huynguyen-hl approved these changes

@ldhyen99 ldhyen99 Awaiting requested review from ldhyen99

Assignees

@ashleythedeveloper ashleythedeveloper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleythedeveloper @namhoang1604 @huynguyen-hl