You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR aims to update the verify URL to include the hash and key returned from the storage service, allowing us to verify its integrity using the included hash and key.
@ldhyen99, can I please confirm that you've tested this implementation by using one of the process services in the reference implementation? I.e. Issued a DPP using processDPP >Store the credential in the storage service > Register credential with IDR > Verify the resulting link has the hash
huynguyen-hl
changed the title
feat: include hash in verify URL of link resolver service
feat: include hash and key in verify URL of link resolver service
Nov 6, 2024
@ldhyen99, can I please confirm that you've tested this implementation by using one of the process services in the reference implementation? I.e. Issued a DPP using processDPP >Store the credential in the storage service > Register credential with IDR > Verify the resulting link has the hash
Hi @ashleythedeveloper, I'll close this PR because it will duplicate Huy's PR (add an encrypted endpoint in the storage service). After discussing, we should handle the hash and key in the storage service instead of the link resolver service. The hash also includes without key when we call constructVerifyURL in here
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
huynguyen-hl
changed the title
What type of PR is this? (check all applicable)
Description
This PR aims to update the verify URL to include the hash and key returned from the storage service, allowing us to verify its integrity using the included hash and key.
Related Tickets & Documents
https://github.com/gs-gs/fa-ag-trace/issues/694
https://github.com/gs-gs/fa-ag-trace/issues/695
Mobile & Desktop Screenshots/Recordings
(v1/credentials):Issue DPP:
Copy the verify URL link:
Go to the verify page:
(/v1/documents):Issue DPP:
Copy the verify URL link:
Go to the verify page:
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?