Unblock fee rate limit, add caption warning about mempool monitors #358
Conversation
src/reducers/transactionReducer.js
Outdated
| const fee = | ||
| feeRateError === "" | ||
| feeRateError === null && |
There was a problem hiding this comment.
Doesn't this need to be an or statement to ignore rate-too-high errors? If I'm reading this correctly fees will only be set if feeRateError is null
feeRateError === null ||
feeRateError === FeeValidationError.FEE_RATE_TOO_HIGH
There was a problem hiding this comment.
Wow, good catch. Such a basic thing, and yet I had missed it. Fixed in 9b491a1
The behavior wasn't causing an error though and the visual feedback on fee rate was correct. This reveals another problem which is that there is a non-unified approach to tracking these values and they seem to desync where the state does not match the visual representation. Not a problem to fix for the scope of this change.
There was a problem hiding this comment.
Thats a good point. We could set the feeRateErrorMessage when fee is an empty string to avoid the disconnect, but I'm also fine with what you are doing now.
Description
This updates unchained-bitcoin to v1.2.0
This change uses the new fee error types provided by unchained-bitcoin v1.2.0 to conditionally display fee error feedback. The conditional in this case is that
FeeValidationError.FEE_RATE_TOO_HIGHis going to be ignored to allow for CPFP transactions to be authored in a high fee environment. A caption has been added to the fee rate input instructing the user to be responsible in researching fee rate acceptance on their own.Does this PR introduce a breaking change?
Does this PR fix an open issue?
Perhaps partially: #169