Fix regression with cookies and assortment products

unchainedshop · Nov 26, 2024 · 549b181 · 549b181
1 parent 3d35192
commit 549b181
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 1 deletion.
diff --git a/examples/kitchensink/.env.defaults b/examples/kitchensink/.env.defaults
@@ -8,5 +8,6 @@ UNCHAINED_SEED_PASSWORD=password
 UNCHAINED_SECRET=secret
 UNCHAINED_CLOUD_ENDPOINT=https://engine.unchained.shop/graphql
 UNCHAINED_TOKEN_SECRET=random-token
+UNCHAINED_COOKIE_SAMESITE=none
 REDIS_DB=0
 MONGOMS_VERSION=8.0.1
diff --git a/examples/kitchensink/.env.schema b/examples/kitchensink/.env.schema
@@ -33,6 +33,8 @@ UNCHAINED_ASSIGN_CART_FOR_USERS=
 UNCHAINED_COOKIE_DOMAIN=
 UNCHAINED_COOKIE_PATH=
 UNCHAINED_COOKIE_NAME=
+UNCHAINED_COOKIE_SAMESITE=
+UNCHAINED_COOKIE_INSECURE=
 UNCHAINED_TOKEN_SECRET=
 DATATRANS_SECRET=
 DATATRANS_SIGN_KEY=

diff --git a/examples/minimal/.env.defaults b/examples/minimal/.env.defaults
@@ -8,5 +8,7 @@ UNCHAINED_SEED_PASSWORD=password
 UNCHAINED_SECRET=secret
 UNCHAINED_CLOUD_ENDPOINT=https://engine.unchained.shop/graphql
 UNCHAINED_TOKEN_SECRET=random-token-that-is-not-secret-at-all
+UNCHAINED_COOKIE_SAMESITE=none
+UNCHAINED_COOKIE_INSECURE=
 REDIS_DB=0
 MONGOMS_VERSION=8.0.1
diff --git a/packages/core-assortments/src/module/configureAssortmentProductsModule.ts b/packages/core-assortments/src/module/configureAssortmentProductsModule.ts
@@ -165,6 +165,8 @@ export const configureAssortmentProductsModule = ({
       if (!options?.skipInvalidation) {
         await invalidateCache({ assortmentIds: [assortmentProduct.assortmentId] });
       }
+
+      return assortmentProduct;
     },
 
     delete: async (assortmentProductId, options) => {

diff --git a/packages/core/src/services/updateUserAvatarAfterUploadService.ts b/packages/core/src/services/updateUserAvatarAfterUploadService.ts
@@ -19,7 +19,7 @@ export const updateUserAvatarAfterUploadService: UpdateUserAvatarAfterUploadServ
   { file },
   context,
 ) => {
-  const { modules, services } = context;
+  const { modules } = context;
   const { userId } = file.meta as { userId: string };
 
   const files = await modules.files.findFiles({