Use process.env in a more performant way

unchainedshop · Jan 9, 2025 · f599aad · f599aad
1 parent 775b762
commit f599aad
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/packages/api/src/express/createERCMetadataMiddleware.ts b/packages/api/src/express/createERCMetadataMiddleware.ts
@@ -5,6 +5,8 @@ import { Request, RequestHandler } from 'express';
 
 const logger = createLogger('unchained:erc-metadata');
 
+const { ROOT_URL = 'http://localhost:4010' } = process.env;
+
 const errorHandler = (res, e) => {
   logger.error(e.message);
   res.writeHead(503);
@@ -29,7 +31,7 @@ const ercMetadataMiddleware: RequestHandler = async (
     }
 
     const { services, localeContext } = req.unchainedContext;
-    const url = new URL(req.url, process.env.ROOT_URL);
+    const url = new URL(req.url, ROOT_URL);
     const parsedPath = path.parse(url.pathname);
 
     if (parsedPath.ext !== '.json') throw new Error('Invalid ERC Metadata URI');

diff --git a/packages/api/src/fastify/ercMetadataHandler.ts b/packages/api/src/fastify/ercMetadataHandler.ts
@@ -4,6 +4,8 @@ import { FastifyRequest, RouteHandlerMethod } from 'fastify';
 
 const logger = createLogger('unchained:erc-metadata');
 
+const { ROOT_URL = 'http://localhost:4010' } = process.env;
+
 const errorHandler = (res) => (e) => {
   logger.error(e.message);
   res.status(503);
@@ -22,7 +24,7 @@ const ercMetadataHandler: RouteHandlerMethod = async (
 ) => {
   try {
     const { services, localeContext } = req.unchainedContext;
-    const url = new URL(req.url, process.env.ROOT_URL);
+    const url = new URL(req.url, ROOT_URL);
 
     if (!url.pathname.toLowerCase().endsWith('.json')) throw new Error('Invalid ERC Metadata URI');
 

diff --git a/packages/core-files/src/module/configureFilesModule.ts b/packages/core-files/src/module/configureFilesModule.ts
@@ -6,6 +6,8 @@ import { filesSettings, FilesSettingsOptions } from '../files-settings.js';
 
 const FILE_EVENTS: string[] = ['FILE_CREATE', 'FILE_UPDATE', 'FILE_REMOVE'];
 
+const { ROOT_URL = 'http://localhost:4010' } = process.env;
+
 export const configureFilesModule = async ({
   db,
   options: filesOptions = {},
@@ -23,8 +25,8 @@ export const configureFilesModule = async ({
       if (URL.canParse(transformedURLString)) {
         const finalURL = new URL(transformedURLString);
         return finalURL.href;
-      } else if (URL.canParse(transformedURLString, process.env.ROOT_URL)) {
-        const finalURL = new URL(transformedURLString, process.env.ROOT_URL);
+      } else if (URL.canParse(transformedURLString, ROOT_URL)) {
+        const finalURL = new URL(transformedURLString, ROOT_URL);
         return finalURL.href;
       }
       return transformedURLString;

diff --git a/packages/plugins/src/warehousing/eth-minter.ts b/packages/plugins/src/warehousing/eth-minter.ts
@@ -12,7 +12,7 @@ import { systemLocale } from '@unchainedshop/utils';
 import { generateDbObjectId } from '@unchainedshop/mongodb';
 import { getFileAdapter } from '@unchainedshop/core-files';
 
-const { MINTER_TOKEN_OFFSET = '0' } = process.env;
+const { MINTER_TOKEN_OFFSET = '0', ROOT_URL = 'http://localhost:4010' } = process.env;
 
 const ETHMinter: IWarehousingAdapter = {
   ...WarehousingAdapter,
@@ -127,7 +127,7 @@ const ETHMinter: IWarehousingAdapter = {
         const isDefaultLanguageActive = locale ? locale?.language === systemLocale.language : true;
         const localization = isDefaultLanguageActive
           ? {
-              uri: `${process.env.ROOT_URL}/erc-metadata/${product._id}/{locale}/${tokenId}.json`,
+              uri: `${ROOT_URL}/erc-metadata/${product._id}/{locale}/${tokenId}.json`,
               default: systemLocale.language,
               locales: allLanguages.map((lang) => lang.isoCode),
             }