-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wall loss example #424
Wall loss example #424
Conversation
Co-authored-by: Sourcery AI <>
@ngmahfouz I was going, to update wlc name too, but that might have side-effects that need to be fixed at that point from other dependencies. |
|
@Gorkowski do you want me to fix the initial mess here? I put the initial function as a placeholder and I left it half-baked. Let me look into it and rewrite the whole thing so that it is more flexible and generic and can be called from anywhere |
I can also write a notebook with references and visualizations, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ngmahfouz Yeah, feel free to refactor and add to this PR. I was thinking of protyping out the wall loss forward simulation.
After that work on the data fitting as a separate PR.
Fixes #402
@ngmahfouz Here is my first cut of the chamber forward simulations. Look at the plots in the notebook to double-check the dynamics look right. Also, some negative concentration values slip in at high concentrations of 1e5 and smaller particle sizes. This is due to the ODE taking too large of a step (i think). Ideas on fixing that would be good :) It's not a significant problem, but something that a novice person could find puzzling if they don't understand it. |
Will review tonight; we can set a a number limiter to ensure it never goes negative ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go! Really nice work. You're making me excited about this work again :)
I will do my best to dedicate at least a week of January (likely last one) on particula ..... sorry too much instability in my life!
Fixes #402