Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vapor Pressure Strategies #450

Merged
merged 7 commits into from
May 6, 2024
Merged

Vapor Pressure Strategies #450

merged 7 commits into from
May 6, 2024

Conversation

Gorkowski
Copy link
Collaborator

Adding interchangeable strategies to calculate vapor pressures and gas concentrations.

And removed the prototype base/notebooks, as we'll build out the next version with condensation, step by step.

Copy link

github-actions bot commented May 1, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://uncscode.github.io/particula/pr-preview/pr-450/
on branch gh-pages at 2024-05-06 01:29 UTC

@Gorkowski Gorkowski marked this pull request as ready for review May 1, 2024 01:16
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Gorkowski - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 2 issues found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Gorkowski Gorkowski requested a review from ngmahfouz May 1, 2024 01:24
@ngmahfouz ngmahfouz enabled auto-merge May 6, 2024 01:23
@ngmahfouz ngmahfouz added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit b56cc51 May 6, 2024
8 checks passed
@ngmahfouz ngmahfouz deleted the vapor-pr branch May 6, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants