Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes: #38

Merged
merged 7 commits into from
Aug 17, 2024
Merged

Changes: #38

merged 7 commits into from
Aug 17, 2024

Conversation

EmmanuelAR
Copy link
Collaborator

1- Add donator contract
2-Add donatorManager contract
3-Add error constant
4-Add donator constant
5-Add new constants references in all the contracts 6-Add new comments to separete the code in sections

@EmmanuelAR
Changes:
3920e6e 
1- Add donator contract
2-Add donatorManager contract
3-Add error constant
4-Add donator constant
5-Add new constants references in all the contracts
6-Add new comments to separete the code in sections
@EmmanuelAR EmmanuelAR requested a review from adrianvrj August 15, 2024 04:01
This was referenced Aug 15, 2024
Closed
Closed
Closed
@EmmanuelAR
Copy link
Collaborator Author

TICKETS:
#33
#22
#7

@EmmanuelAR
Changes:
9044794 
1-Fix error message to be felt252
2-Fix module errors_constants name
3-remove asser!( to assert(
4-Fix parameters in some methods
5-use read() and write()
6-add modules pending in constants cairo
@EmmanuelAR
Change getDonatorByAddress to be a get method and remove unused param…
01917a5 
…eter
@EmmanuelAR
Fix asserts and asserts!
3d9f6d4
@EmmanuelAR
add donatorManager and Donator commands
14ce79b
adrianvrj
adrianvrj reviewed Aug 17, 2024
View reviewed changes
contracts/src/constants/donator/donator_constants.cairo Outdated
// DONATOR CONSTANTS
// *************************************************************************
pub mod DonatorConstants {
pub const INICIAL_LEVEL: u32 = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be INITIAL

adrianvrj
adrianvrj reviewed Aug 17, 2024
View reviewed changes
contracts/src/constants/donator/donator_constants.cairo Outdated
// *************************************************************************
pub mod DonatorConstants {
pub const INICIAL_LEVEL: u32 = 1;
pub const INICIAL_MAX_STARKS_DONATION_TO_NEXT_LEVEL: u64 = 10;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@EmmanuelAR EmmanuelAR marked this pull request as ready for review August 17, 2024 22:53
adrianvrj
adrianvrj requested changes Aug 17, 2024
View reviewed changes
Copy link
Member

@adrianvrj adrianvrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of orthography changes, everything else looks good

This was linked to issues Aug 17, 2024
Add enums for errors and msg handlings #22
Closed
Add donators manager #33
Closed
Add Donator contract #7
Closed
@adrianvrj adrianvrj merged commit b2b1017 into undefinedorgcr:main Aug 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianvrj adrianvrj adrianvrj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add donators manager Add enums for errors and msg handlings Add Donator contract
2 participants
@EmmanuelAR @adrianvrj