Enzyme AD - almost work! #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Nov 28, 2024
| code::Const, | ||
| xs::Duplicated, ys::Duplicated, sx::Const, sy::Const, size_dict::Const) | ||
| xval = EnzymeRules.overwritten(config)[3] ? tape : xs.val | ||
| for i=1:length(xs.val) |
There was a problem hiding this comment.
They should be the same, no?
There was a problem hiding this comment.
if it's a tuple, yes becaise it's immutable. If it's an array someone might've pushed/pop'd to it in between forward and reverse pass
wsmoses
reviewed
Nov 28, 2024
| xs::Duplicated, ys::Duplicated, sx::Const, sy::Const, size_dict::Const) | ||
| xval = EnzymeRules.overwritten(config)[3] ? tape : xs.val | ||
| for i=1:length(xs.val) | ||
| xs.dval[i] .+= OMEinsum.einsum_grad(OMEinsum.getixs(code.val), |
There was a problem hiding this comment.
is there a reason for doing the for loop here, can this just be broadcasted for all of them? Or even more ideally could the dval be an extra argument to einsum/einsum_grad?
There was a problem hiding this comment.
Here xs is a tuple of arrays, here einsum_grad tries to get gradient of the i-th input tensor. You are right, it is better to design an inplace version for better performance. I will consider making this change in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.