[UNDERTOW-2372] Add request size and response size exchange attribute… #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems like a bit of duplicate of #1536 |
baranowb
added
duplicate
baranowb
requested changes
Jul 26, 2024
| } | ||
| requestSize += calculateRequestLineSize(exchange); | ||
| requestSize += exchange.getRequestHeaders().getHeadersBytes(); | ||
| // add 2 bytes for CRLF, and 2 bytes for ": " between header name and value |
There was a problem hiding this comment.
Ive already talked with Marek. This type of code needs detailed exaplanation.
|
Ive removed duplicate, as its vaguely connected to other PR, which has tad different way of getting size. |
baranowb
approved these changes
Jul 29, 2024
ropalka
reviewed
Jul 30, 2024
| public static final ExchangeAttribute INSTANCE = new RequestSizeAttribute(); | ||
|
|
||
| @Override | ||
| public String readAttribute(HttpServerExchange exchange) { |
There was a problem hiding this comment.
What if HTTP 2 protocol is in use? The calculations here expect HTTP 1.1 is being used.
| public static final ExchangeAttribute INSTANCE = new ResponseSizeAttribute(); | ||
|
|
||
| @Override | ||
| public String readAttribute(HttpServerExchange exchange) { |
There was a problem hiding this comment.
What if HTTP 2 protocol is in use? The calculations here expect HTTP 1.1 is being used.
There was a problem hiding this comment.
good point, but AFAIR we cant account for, for instance, header compression? Also, even for H1 with compression this will be off?
@xjusko ^^ ?
…s(sizes include headers).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s(sizes include headers).
https://issues.redhat.com/browse/UNDERTOW-2372