Implemented new features: first issue and second issue #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e home.html file, always preserving the previous functionalities
Deleted classifications_histogram.py because the portion of code I needed now is inside classifications.py Modified home.html to have another 'here' button for the new functionality to implement
… the plotted image in the created imagenet_histogram directory
…make more fancy the web interface )
… verify every routes work correctly
…code. Transformed images are saved in a new folder
…t, putting default value to 1.0 to all enhancement's factors
First issue
Second issue
maurapintor
reviewed
Jan 30, 2023
There was a problem hiding this comment.
The code looks good. The only thing left is removing some comments in two of the files. Also, I would suggest that you improve the documentation of the pull request itself. You can add the links to the issues of the original repository to clarify what you are solving ("first and second issue" is not much informative). As soon as these things are fixed, the assignment will be considered done.
test_historgram.py
Outdated
|
|
||
|
|
||
| img_one_ch = 'app/static/imagenet_subset/n01443537_goldfish.JPEG' | ||
| # print(img_one_ch) |
There was a problem hiding this comment.
I think these are leftover comments that can be removed. @davide-scintu Can you fix this?
test_historgram.py
Outdated
| # print(type(img_one_ch)) | ||
| plot_histogram(img_one_ch) | ||
|
|
||
| # img_rgb = 'app/static/imagenet_subset/n01443537_goldfish.JPEG' |
trans_test.py
Outdated
| """IMAGE TRANSFORMATIONS""" | ||
|
|
||
| """Open and image and show it""" | ||
| # im = Image.open('app/static/imagenet_subset/n01443537_goldfish.JPEG') |
There was a problem hiding this comment.
cleanup comments in this file as well please
First Issue Pull
Second Issue Pull
davide-scintu
changed the title
maurapintor
reviewed
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Image Histogram
This feature allows a user to choose an image from the dataset, saving it and have its histogram shown compared to its original feedback image.
Image Transformation
This feature allows a user to choose an image from the dataset and choose a value from -10.0 to +10.0 (with 0.1 step) to pass to enhancements factors to modify it. The result shows the difference between the output image and the original one.
Old functionalities preserved
Other information:(does the pr fix some issues? Tag them with #)
Closed first issue : Image Histogram #1
Closed second issue : Image transformation #2